Skip to content

Gemini Integration#29

Open
Archillesjakins wants to merge 18 commits intoshure-dev:developfrom
Archillesjakins:Gemini-integration
Open

Gemini Integration#29
Archillesjakins wants to merge 18 commits intoshure-dev:developfrom
Archillesjakins:Gemini-integration

Conversation

@Archillesjakins
Copy link
Copy Markdown

@Archillesjakins Archillesjakins commented Aug 27, 2024

Changed the generative model to Gemini
Changed the setup configuration
Changed the test_logger compatible to the gemini model
Adjusted the query.py file for gemini model

@Archillesjakins
Copy link
Copy Markdown
Author

I have fixed the necessary conflicts you can now approve merge on the develop branch. Thanks!

extractor.py Outdated
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this file?

wandb.init(project=project_name, settings=wandb.Settings(_disable_stats=True))

def extract_experimental_conditions(code):
def extract_experimental_conditions_gemini(code):
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you do not have to make two functions, you can have one function where you use if branch to switch openai and gemini

Comment on lines -24 to -37
{{
"method":"str",
"dataset":"str",
"task":"str",
"accuracy":"",
"other_param_here":{
"other_param_here":"",
"other_param_here":"",
},
"other_param_here":"",
...
"condition_as_natural_langauge":["Small dataset."],
"advice_to_improve_acc":["Use bigger dataset.","Use more simple model."]
}}
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSON is not necessary?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please check on the suggestions I made on the issues post.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an implementing feature, we can ignore for now.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should at least make it more clear what role intended for that query function on the logllm.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you may not need to change this file

@shure-dev
Copy link
Copy Markdown
Owner

shure-dev commented Aug 30, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

2 participants